v31.1-roots.1 · Commit 8: [PATCH 08/17] chore(roots): integrate v31 identity and maintenance tooling

doc/roots-v31-port-review.md

Before: doc/roots-v31-port-review.md · After: doc/roots-v31-port-review.md

File metadata

index 778324d7aa8c24174b1626fce8da5d44ee8f97b6..2732a300ad5d2aeabe2a811531685bb69ba0bcbb 100644

Download original patch · Release notes

Diff rows 1–190 of 190. Line numbers refer to the original before/after files.

+ Added− RemovedUnmarked lines are context.

Scroll the code area horizontally to read long lines. The two line-number columns refer to before and after.

doc/roots-v31-port-review.md CHANGED Viewed

@@ -820,3 +820,190 @@ macOS, BSD and 32-bit execution are not proved by these runs; their conditional
 branches are retained from the source/native APIs, with the Windows file-size
 comparison expressed through `LARGE_INTEGER::QuadPart`. Whole-L12 acceptance
 and broader platform/runtime matrices remain separate gates.
+## L13.1 identity and desktop integration
+The candidate retains Roots client identity, source/issue URLs and original
+Roots PNG/ICO/ICNS/SVG/splash assets from `c592888088`. The Windows resource path
+correction (`25f889f97e`) uses a configured resource file with absolute build-time
+asset paths. Upstream protocol/legacy file names remain unchanged; this is not
+mass rebranding. Core and Knots lineage remains explicit in the candidate README,
+and binary copyright output retains Bitcoin Core credit alongside Roots.
+Jaromil and devjoinedthechat source credit is retained in the thematic mapping.
+The release version block from `7791eede50` now checks the selected `31.1` base:
+untagged/default builds identify `v31.1-roots.1`; valid `CLIENT_VERSION_TAG`
+values provide `v31.1-roots.<positive revision>` identity without Git metadata.
+Numeric protocol versions and BIP14 `Satoshi` remain upstream-compatible.
+`roots_build_identity` exercises the actual production CMake block: default,
+two valid tag revisions, and five wrong-base/invalid-tag cases. The six headless
+tools and actual Qt6 GUI identify Bitcoin Roots in captured `--version` output.
+These are local candidate build names, not published release claims.
+QR export retains the quiet zone, adds font-aware caption layout and updates
+receive QR images on the money-font setting signal. The QString-size correction
+from `3e13c1f213` uses the native Qt5/Qt6 size type. Qt apptests check Roots
+icon/splash resources, PNG round-trip, clipboard export and quiet-zone geometry.
+The wallet fixture drives the actual receive dialog's Save Image action into a
+temporary PNG, compares it to the displayed export image, and checks refresh
+through the production money-font setting. Keys, settings and regtest data are
+disposable; no real wallet or network broadcast is involved.
+Windows taskbar progress is carried behind `WITH_TASKBAR_PROGRESS`, enabled
+only for Windows GUI builds. It registers/removes the native event filter with
+the window lifetime and clears progress at synchronization completion. Qt5/Qt6
+use their respective native-filter signatures. Linux configurations generate an
+undefined taskbar macro; local tests do not establish Windows COM/event behavior.
+Windows/macOS/32-bit runtime and cross-build evidence remains unavailable.
+Example configuration is generated by the inherited generator from this exact
+candidate's isolated `bitcoind --help` output and passes byte-identical repeat
+regeneration. The selected profile has wallet enabled and IPC/USDT/ZeroMQ
+disabled; its generated output omits the inherited optional ZeroMQ section.
+This omission describes the tested help profile and does not retire ZeroMQ
+support. No older source help/config content was copied into the generated file.
+After the missing generator was installed externally, all seven manuals were
+regenerated using the existing `contrib/devtools/gen-manpages.py` and GNU
+help2man 1.49.3. Isolated wrappers invoke the unchanged tested headless binaries
+and Qt6 GUI; daemon/wallet/GUI help has an explicit disposable regtest datadir.
+The generator uses `LC_ALL=C` and `SOURCE_DATE_EPOCH=1791755546` (the starting
+candidate commit timestamp). A second generation into a temporary directory
+matches all seven manuals byte for byte. The manuals retain Bitcoin Core
+copyright alongside Roots and contain no local wrapper/datadir paths. No manual
+was hand-edited. Like the example config, they reflect the tested no-ZeroMQ
+profile rather than proving optional-library availability.
+Exact focused commands, build/binary/source hashes, result counts and the
+receive/export evidence matrix are recorded below as local verification evidence;
+L13.2 maintenance and the full L13 acceptance suite remain separate gates.
+Focused L13.1 evidence on the uncommitted tree starting at `44c15f2cde`:
+- `cmake --build <profile> --target bitcoin-qt test_bitcoin-qt -j 2`
+  passed for the existing actual Qt5 and Qt6 profiles. The headless profile
+  built `bitcoin bitcoind bitcoin-cli bitcoin-tx bitcoin-wallet bitcoin-util`.
+- `python3 test/cmake/test_identity.py -v` passed 3 tests;
+  `ctest --test-dir <headless-profile> -R roots_build_identity --output-on-failure`
+  passed its one registered test.
+- The actual `test_bitcoin-qt` binary passed 21 result rows, including
+  initialization/cleanup, in each of eight Xvfb profiles: Qt5/Qt6 × 1280×800/
+  1920×1080 × 100%/150% application font scale. `QT_SCALE_FACTOR=1` is retained;
+  this is font scaling evidence, not physical DPI scaling. Each run has a
+  60-second timeout and isolated XDG settings/runtime data.
+- Each profile records receive controls, the receive QR dialog and the PNG
+  save chooser at the full screen dimensions, plus the actual exported QR PNG:
+  24 screenshots and 8 exported images. The save chooser uses Qt's non-native
+  dialog for deterministic automated interaction. Screens retain preceding
+  test widgets in the background; their synthetic balances are fixture facts.
+  Representative Qt5/Qt6 receive views at 1280×800/150%, the Qt6 save chooser,
+  and the exported QR at 1920×1080/150% were visually inspected: the affected
+  payment text, QR caption and Save/Copy/OK actions were readable.
+- `BITCOIND=<isolated-candidate-help-wrapper> bash contrib/devtools/gen-bitcoin-conf.sh`
+  regenerated the example config; a second generation into a temporary file
+  compared byte for byte. The wrapper passes an explicit disposable regtest
+  datadir. An initial unwrapped help invocation hit the read-only default
+  wallet directory and did not produce valid help; only the corrected isolated
+  invocation supplies this generated file and current help evidence.
+- `BUILDDIR=<isolated-candidate-help-wrappers> HELP2MAN=/usr/bin/help2man
+  QT_QPA_PLATFORM=offscreen XDG_CONFIG_HOME=<isolated-settings>
+  SOURCE_DATE_EPOCH=1791755546 LC_ALL=C python3 contrib/devtools/gen-manpages.py`
+  generated all seven manuals. Repeat generation with `MANDIR=<temporary-directory>`
+  and byte comparison passed 7/7; current version, retained credit and absence
+  of local-path leakage were checked in each file. Generated differences are
+  candidate version/date/URLs/credit, current Roots help/defaults and omission
+  of the unsupported-in-this-profile optional ZeroMQ section.
+- `python3 test/lint/check-doc.py` and `git diff --check` passed.
+Local `.gestalt/l13-integration` evidence includes exact commands/results,
+`l13.1-snapshot.json` with source/binary SHA256s, and
+`l13.1-gui-snapshot.json` with image SHA256s/dimensions and all eight result
+counts. This focused evidence does not substitute for the later full L13 suite,
+Windows/macOS/32-bit tests or optional ZeroMQ/IPC/USDT profiles. On resumption,
+31 previous source paths, 22 binaries and all 32 identity images matched their
+recorded hashes; unchanged GUI and focused test evidence was reused.
+## L13.2 maintenance, portable export and CI cadence
+This adaptation retains the source classifier, exact canonical-promotion CI
+proof, conservative nightly change gate, strict APT refresh, release-source/tag
+validation, archive/COPYING checks, portable export/replay, optional notice
+helpers, required manifest signing and new-draft-only tools. The checked-in
+public key and expected fingerprint remain unchanged. Only a permanent tag
+push can enter the signing environment; manual rehearsal has read-only
+permissions, requires an absent future tag and cannot create a release. Signing
+capability, signature/source mismatch and any existing draft/public release
+still fail. No dispatch, publishing, remote ref mutation or signing with a real
+secret was performed locally.
+The remaining maintenance-only history is folded by responsibility:
+| Source commits | Candidate disposition |
+| --- | --- |
+| `5c210e17fb`, `9f1780f330`, `4570a6a547` | Adapted CI/platform/assurance entry points and maintained fixtures; retain v31 native cache actions, compiler profiles, build script and test runners. Feature-owned code/tests stay in their earlier themes. |
+| `9da5851410`, `26b691e4f3`, `201927c151`, `e819a07a4a`, `56e2894760` | Adapted additive classification, conservative scheduled-change gate, strict APT retry, optional-feature selection and branded archive checks. Broad platform jobs move to nightly/manual; no optional capability is retired. |
+| `83fa42a963`, `f5182f0e3a`, `7791eede50`, `11c84c39ef`, `0efa437e29`, `f2595557d9`, `38bc7ec2ce`, `df8aa8e2b7`, `ddae467a78`, `778ff50d19`, `c474825f96`, `17e1d484ab` | Kept/adapted final release-source/rehearsal, five-platform archives, COPYING, portable replay, trusted signing/new-draft-only and promotion-proof safeguards. Corrective source history is folded; expanded notices remain optional/deferred. The configured-version sub-aspect is also preserved in L13.1. |
+| `b0b235d6a1`, `f4066e5282`, `30f673a4bc`, `a13f28e2f4`, `1517d925b2`, `628bdf4e38`, `02464df449`, `089888acdd` | Adapted relevant candidate identity, maintained workflow guidance, provenance and credit; existing upstream release notes remain historical. Final aggregate/range evidence stays L14. |
+| `1b73fe3d21`, `ec9db369f5`, `c592888088`, `9b778b9a23` | Remaining CI/build/GUI assertions are carried or adapted to v31 paths and the accepted owning-feature implementations; semantic source content is not reintroduced as a second chronological series. |
+PR/development execution now uses the existing `ci/test_run_all.sh` and native
+runners with a small affected-regression selector. Complete known paths select
+wallet, network, policy/mining and runtime acceptance groups; mixed changes take
+the union and incomplete/unknown paths choose broad fast coverage. Fast
+functional execution is bounded at 900 seconds; selected libFuzzer smoke uses
+5 seconds/target and a 15-second outer timeout. The nine possible smoke targets
+have fixed seed 1 and per-input limits; input counts are results, not quotas.
+The standalone selector also exposes a 60-second/target, 75-second outer
+nightly campaign and a 7200-second selected-functional budget.
+Scheduled/manual assurance retains full ASan/USDT/Qt, TSan/MSan, full Linux,
+macOS and Windows fuzz corpora, extended/previous-release tests, tidy, i686
+no-IPC, ARM32, kernel and native Windows/macOS smokes. Linux full-corpus replay
+also runs the longer selected campaigns. Ordinary PRs have actual Qt tests,
+fast native sanitizers/affected regressions and bounded fuzz smoke; explicit
+labels can still request fresh heavy coverage. Every selected required PR job
+must succeed. Nightly jobs with empty selected matrices are skipped before
+strategy expansion; failed/incomplete schedule history retries. Explicit job
+budgets and failure artifacts are documented in [CI guidance](/ci/README.md).
+The v31 action/preset adaptations include current cache-action paths, LLVM 22
+profiles, the upstream i686 no-IPC profile and VS2026 static builds. Windows
+GUI jobs explicitly select the optional `miniupnpc` vcpkg feature when requiring
+that library. Wallet-only Windows fuzz manifests explicitly disable ZMQ. The
+vcpkg baseline is unchanged. Actual Windows/macOS/32-bit and hosted CI jobs were
+not executed locally; static command/dependency checks do not establish their
+success. No dependency was installed by this executor.
+Focused local verification:
+- Maintained source-tool tests cover classifiers, promotion proof, schedule
+  gates, release source/tag/absence checks, archives/COPYING, optional notices,
+  signing and new-draft refusal. The maintained suite passed 124 cases;
+  after narrowing the mempool-argument selection, its six affected behavioral
+  cases passed (125 current cases in aggregate with unchanged remaining tests).
+- New tests execute actual nightly selector and required-result Bash blocks,
+  plus affected selection/union/fallback, fast/nightly command budgets, real
+  process timeout and retained failure logs. All pass. Parsed workflow YAML,
+  dependency references/local actions and embedded Bash syntax validate locally.
+  `actionlint` is unavailable; no hosted workflow was dispatched.
+- The actual budget runner executed three wallet scripts successfully, then
+  the conservative fallback for the mempool-argument path executed all 16 Roots
+  scripts successfully. Its final narrower policy/mining/runtime selection is
+  covered by the six behavioral cases and those matching native test passes.
+  Tested product binaries and functional fixtures were unchanged.
+- The new fast native ASan/UBSan profile configured on local Clang and built
+  `bitcoin_clientversion`; this bounded probe is not a full sanitizer-profile
+  pass. Sixteen changed shell scripts passed `bash -n` and ShellCheck.
+- Temporary export verification snapshots the exact uncommitted candidate in
+  a disposable local clone, validates against authenticated v31.1 commit
+  `9be056a8a72b624dae9623b2f7bded92c2a21c91`, and invokes the actual
+  `create-patch-series.sh`. Its internal `git am -3 --keep-cr` replay matches
+  the snapshot outside `.github/**`; Core's `.github/**` tree is unchanged.
+  Exported content retains Jaromil/devjoinedthechat credit. Synthetic snapshot
+  commits/refs/tags exist only in the disposable fixture; candidate/source refs,
+  index and history remain unchanged.
+Exact commands, pass counts, intended cumulative/delta paths and current source,
+binary/tool-test/export hashes are local evidence under
+`.gestalt/l13-integration`. L13.1 GUI/capture/manual evidence remains unchanged
+and is reused. Full L13 acceptance and the final candidate/hosted matrix remain
+later gates, rather than being inferred from these focused checks.