Skip to content
Bitcoin Roots

v30.3-roots.1 · Commit 67: [PATCH 67/68] fix(release): defer expanded dependency notice coverage

ci/test/test_runner_release_notices.py

Before: ci/test/test_runner_release_notices.py · After: ci/test/test_runner_release_notices.py

File metadata
index 09d309554a1384a37a9a8ed2cee75d76bc0862a3..ddba25f98217f631f8699a5cef1b778f8551c5be 100755

Download original patch · Release notes

Diff rows 1–25 of 25. Line numbers refer to the original before/after files.

+ Added− RemovedUnmarked lines are context.

Scroll the code area horizontally to read long lines. The two line-number columns refer to before and after.

ci/test/test_runner_release_notices.py CHANGED
@@ -202,19 +202,15 @@ class RunnerNoticeTest(unittest.TestCase):
202
202
  self.assertNotIn('BITCOIN_ROOTS_GPG_SK', text)
203
203
  self.assertNotIn('fixture-never-export', text)
204
204
 
205
- def test_all_runner_workflow_blocks_stage_and_validate_before_upload(self):
205
+ def test_current_release_stages_copying_without_mandatory_notice_collection(self):
206
206
  workflow = (ROOT / '.github/workflows/release.yml').read_text()
207
+ self.assertNotIn('runner-notices.py', workflow)
208
+ self.assertNotIn('ci/release/notices.py', workflow)
209
+ self.assertNotIn('RELEASE_NOTICE_PLATFORM', workflow)
207
210
  for job, following in [('linux-release', 'windows-release'), ('windows-release', 'macos-release'), ('macos-release', 'publish-release')]:
208
211
  block = workflow.split(f' {job}:', 1)[1].split(f' {following}:', 1)[0]
209
- if job == 'linux-release':
210
- self.assertIn('export RELEASE_NOTICE_PLATFORM=', block)
211
- hook = (ROOT / 'ci/test/03_test_script.sh').read_text()
212
- self.assertIn('if [[ -n "${RELEASE_NOTICE_PLATFORM:-}" ]]', hook)
213
- self.assertIn('--depends "$DEPENDS_DIR" --host "$HOST"', hook)
214
- else:
215
- self.assertLess(block.index('ci/release/runner-notices.py'), block.index('ci/release/notices.py stage'))
216
- self.assertLess(block.index('ci/release/notices.py stage'), block.index('ci/release/notices.py validate'))
217
- self.assertLess(block.index('ci/release/notices.py validate'), block.index('uses: actions/upload-artifact'))
212
+ self.assertLess(block.index('ci/release/archive.py stage-copying'), block.index('ci/release/archive.py validate'))
213
+ self.assertLess(block.index('ci/release/archive.py validate'), block.index('uses: actions/upload-artifact'))
218
214
 
219
215
 
220
216
  if __name__ == '__main__':