v30.3-roots.1 · Commit 13: [PATCH 13/68] fix(qt): resolve Windows release icons
ci/test/test_windows_gui_workflows.py
Before: ci/test/test_windows_gui_workflows.py · After: ci/test/test_windows_gui_workflows.py
File metadata
index b49ee06635f325255322a08d8ac8adc65e7eac03..368ebb1d7fb9fe02d6a9278a970fb73acb41246c 100755
Download original patch · Release notes
Diff rows 1–20 of 20. Line numbers refer to the original before/after files.
+ Added− RemovedUnmarked lines are context.
Scroll the code area horizontally to read long lines. The two line-number columns refer to before and after.
ci/test/test_windows_gui_workflows.py
CHANGED
|
@@ -13,6 +13,7 @@ ROOT = Path(__file__).resolve().parents[2]
|
|
|
13
13
|
CI_WORKFLOW = ROOT / ".github/workflows/ci.yml"
|
|
14
14
|
RELEASE_WORKFLOW = ROOT / ".github/workflows/release.yml"
|
|
15
15
|
ROOTS_LOGO = ROOT / "src/qt/res/src/bitcoinroots-logo.svg"
|
|
16
|
+
WINDOWS_RESOURCES = ROOT / "src/qt/res/bitcoin-qt-res.rc"
|
|
16
17
|
|
|
17
18
|
|
|
18
19
|
def job(workflow, name):
|
|
@@ -32,6 +33,13 @@ class WindowsGuiWorkflowTest(unittest.TestCase):
|
|
|
32
33
|
_, _, viewbox_width, viewbox_height = logo.attrib["viewBox"].split()
|
|
33
34
|
self.assertEqual(viewbox_width, viewbox_height)
|
|
34
35
|
|
|
36
|
+
def test_windows_resources_use_source_absolute_icon_paths(self):
|
|
37
|
+
resources = WINDOWS_RESOURCES.read_text(encoding="utf-8")
|
|
38
|
+
icon_lines = [line for line in resources.splitlines() if " ICON " in line]
|
|
39
|
+
self.assertEqual(len(icon_lines), 4)
|
|
40
|
+
for line in icon_lines:
|
|
41
|
+
self.assertIn('@CMAKE_CURRENT_SOURCE_DIR@/res/icons/', line)
|
|
42
|
+
|
|
35
43
|
def assert_static_gui_assets(self, windows_job):
|
|
36
44
|
self.assertNotIn("setup-windows-gui-tools", windows_job)
|
|
37
45
|
self.assertNotIn("-DRSVG_CONVERT=", windows_job)
|