v29.4-roots.3 · Commit 3: [PATCH 03/30] policy: restore conservative relay and network controls

test/functional/p2p_compactblocks_extratxs.py

Before: /dev/null · After: test/functional/p2p_compactblocks_extratxs.py

File metadata

new file mode 100755
index 0000000000000000000000000000000000000000..156c0785e9460c176b4e77e5d790ff5efb8fd8b0

Download original patch · Release notes

Diff rows 401–513 of 513. Line numbers refer to the original before/after files.

+ Added− RemovedUnmarked lines are context.

Scroll the code area horizontally to read long lines. Before is on the left; after is on the right. Unified view fits narrow screens more easily.

test/functional/p2p_compactblocks_extratxs.py ADDED Viewed

	@@ -0,0 +1,513 @@ (continued)

+        test_count = 100
+        rejected_txs = self.populate_extra_pool(test_count, target_size=20000)
+        indices = list(range(test_count))
+        result = self.send_compact_block(rejected_txs, indices)
+        # Find the boundary - how many fit vs how many were evicted
+        num_evicted = len(result["missing_indices"])
+        num_fit = test_count - num_evicted
+        # Now restart and add exactly the number that fit
+        self.restart_node_with_limit(memory_mb=limit_mb)
+        rejected_txs = self.populate_extra_pool(num_fit, target_size=20000)
+        # Verify all fit
+        indices = list(range(num_fit))
+        result = self.send_compact_block(rejected_txs, indices)
+        assert result["missing_indices"] == [], f"Expected all {num_fit} transactions to fit at boundary"
+        # Add one more transaction - should evict exactly one
+        self.log.info("Adding one more transaction at the boundary...")
+        self.populate_extra_pool(1, target_size=20000)
+        # Check original transactions again
+        result2 = self.send_compact_block(rejected_txs, indices)
+        assert len(result2["missing_indices"]) == 1, "Expected exactly 1 eviction at boundary"
+        assert result2["missing_indices"] == [0], "Expected oldest transaction (0) to be evicted"
+        self.log.info("Size limit boundary behavior verified - one transaction evicted when limit exceeded")
+    def test_extratxnsize_small_limit(self):
+        """Test extra transaction pool with very small size limit (0.1 MB)."""
+        self.log.info("Testing extra transaction pool with 0.1 MB size limit...")
+        limit_mb = 0.1
+        self.restart_node_with_limit(memory_mb=limit_mb)
+        test_count = 100
+        rejected_txs = self.populate_extra_pool(test_count, target_size=2000)
+        indices = list(range(test_count))
+        result = self.send_compact_block(rejected_txs, indices)
+        # Find the boundary - how many fit vs how many were evicted
+        num_evicted = len(result["missing_indices"])
+        num_fit = test_count - num_evicted
+        # fill exact capacity
+        self.restart_node_with_limit(memory_mb=limit_mb)
+        rejected_txs = self.populate_extra_pool(num_fit, target_size=2000)
+        indices = list(range(num_fit))
+        result = self.send_compact_block(rejected_txs, indices)
+        assert result["missing_indices"] == [], f"Expected all {num_fit} transactions to fit at boundary"
+         # Add one more transaction - should evict exactly one
+        self.log.info("Adding one more transaction at the boundary...")
+        self.populate_extra_pool(1, target_size=2000)
+        # Check original transactions again
+        result = self.send_compact_block(rejected_txs, indices)
+        assert len(result["missing_indices"]) == 1, "Expected exactly 1 eviction at boundary"
+        assert result["missing_indices"] == [0], "Expected oldest transaction (0) to be evicted"
+        self.log.info("Small size limit boundary behavior verified - one transaction evicted when limit exceeded")
+    def test_extratxnsize_large_transaction_exceeds_limit(self):
+        """Test that a transaction larger than the entire size limit is rejected."""
+        self.log.info("Testing large transaction that exceeds size limit...")
+        limit_mb = 0.5 # 0.5 MB/500KB
+        self.restart_node_with_limit(memory_mb=limit_mb)
+        # Create a 600KB transaction (larger than 500KB limit)
+        # This should be rejected from mempool AND not stored in extra pool
+        rejected_txs = self.populate_extra_pool(1, target_size=600000) # 600 KB
+        # try block reconstruction
+        result = self.send_compact_block(rejected_txs, [0])
+        # Verify the transaction is NOT available (was not stored in extra pool)
+        assert len(result["missing_indices"]) == 1, "Large transaction should not be stored in extra pool"
+    def run_test(self):
+        self.wallet = MiniWallet(self.nodes[0])
+        # Setup the p2p connection
+        self.segwit_node = self.nodes[0].add_p2p_connection(TestP2PConn())
+        # Create UTXOs for testing
+        self.make_utxos()
+        # Ensure segwit is active
+        assert softfork_active(self.nodes[0], "segwit")
+        # Test policy rejection types first
+        self.test_policy_rejection_types()
+        # Extra Txn capacity tests
+        self.test_extratxnpool_disabled()
+        self.test_extratxnpool_capacity_and_wraparound()
+        self.test_single_extratxnpool_capacity()
+        self.test_extratxn_invalid_parameters()
+        # Extra Txn size tests
+        self.test_extratxnsize_zero_limit()
+        self.test_extratxnsize_eviction()
+        self.test_extratxnsize_boundary()
+        self.test_extratxnsize_small_limit()
+        self.test_extratxnsize_large_transaction_exceeds_limit()
+if __name__ == '__main__':
+    CompactBlocksBlockReconstructionLimitTest(__file__).main()