Skip to content
Bitcoin Roots

v29.4-roots.2 · Commit 10: [PATCH 10/21] fix: harden final Roots assurance

test/functional/wallet_bumpfee.py

Before: test/functional/wallet_bumpfee.py · After: test/functional/wallet_bumpfee.py

File metadata
index 9cec77fb18451d10f23d58723ec6b299f686c301..ab7c1d0b8d0caf822bc98a083471f962f7f35249 100755

Download original patch · Release notes

Diff rows 1–17 of 17. Line numbers refer to the original before/after files.

+ Added− RemovedUnmarked lines are context.

Scroll the code area horizontally to read long lines. The two line-number columns refer to before and after.

test/functional/wallet_bumpfee.py CHANGED
@@ -406,13 +406,13 @@ def test_notmine_bumpfee(self, rbf_node, peer_node, dest_address):
406
406
  psbt = rbf_node.walletprocesspsbt(psbt)
407
407
  psbt = peer_node.walletprocesspsbt(psbt["psbt"])
408
408
  res = rbf_node.testmempoolaccept([psbt["hex"]])
409
- assert res[0]["allowed"]
409
+ assert res[0]["allowed"], res[0]
410
410
  assert_greater_than(res[0]["fees"]["base"], old_fee)
411
411
 
412
412
  self.log.info("Test that psbtbumpfee works for non-owned inputs")
413
- psbt = rbf_node.psbtbumpfee(txid=rbfid)
414
- finish_psbtbumpfee(psbt["psbt"])
415
-
413
+ # The default-feerate path is covered by test_simple_bumpfee_succeeds(). Use
414
+ # an explicit margin here because the external input's final ECDSA signature
415
+ # size is unknown until the other wallet signs the replacement.
416
416
  psbt = rbf_node.psbtbumpfee(txid=rbfid, fee_rate=old_feerate + 10)
417
417
  finish_psbtbumpfee(psbt["psbt"])
418
418